<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Tests][896] trunk: Remove ability to provide an extra description to the @ticket annotation, added in [984].</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://unit-tests.trac.wordpress.org/changeset/896">896</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2012-07-09 16:12:47 +0000 (Mon, 09 Jul 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove ability to provide an extra description to the @ticket annotation, added in <a href="http://unit-tests.trac.wordpress.org/changeset/984">[984]</a>.
This extra text causes problems when you try to use a ticket # as a group name, which phpunit supports.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkincludestestcasephp">trunk/includes/testcase.php</a></li>
<li><a href="#trunkteststest_includes_themephp">trunk/tests/test_includes_theme.php</a></li>
<li><a href="#trunkteststest_includes_wpscriptsphp">trunk/tests/test_includes_wp-scripts.php</a></li>
<li><a href="#trunkteststest_includes_wpstylesphp">trunk/tests/test_includes_wp-styles.php</a></li>
<li><a href="#trunkteststest_userphp">trunk/tests/test_user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkincludestestcasephp"></a>
<div class="modfile"><h4>Modified: trunk/includes/testcase.php (895 => 896)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/includes/testcase.php 2012-07-09 15:37:12 UTC (rev 895)
+++ trunk/includes/testcase.php 2012-07-09 16:12:47 UTC (rev 896)
</span><span class="lines">@@ -124,14 +124,10 @@
</span><span class="cx"> return;
</span><span class="cx"> $tickets = PHPUnit_Util_Test::getTickets( get_class( $this ), $this->getName() );
</span><span class="cx"> foreach ( $tickets as $ticket ) {
</span><del>- $annotation = explode( ' ', $ticket, 2 );
- $ticket = $annotation[0];
- $message = isset( $annotation[1] ) ? $annotation[1] : '';
-
</del><span class="cx"> if ( is_numeric( $ticket ) ) {
</span><del>- $this->knownWPBug( $ticket, $message );
</del><ins>+ $this->knownWPBug( $ticket );
</ins><span class="cx"> } elseif ( 'UT' == substr( $ticket, 0, 2 ) ) {
</span><del>- $this->knownUTBug( substr( $ticket, 2 ), $message );
</del><ins>+ $this->knownUTBug( substr( $ticket, 2 ) );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -139,27 +135,27 @@
</span><span class="cx"> /**
</span><span class="cx"> * Skips the current test if there is an open WordPress ticket with id $ticket_id
</span><span class="cx"> */
</span><del>- function knownWPBug( $ticket_id, $message = '' ) {
</del><ins>+ function knownWPBug( $ticket_id ) {
</ins><span class="cx"> if ( ! WP_TESTS_FORCE_KNOWN_BUGS && ! TracTickets::isTracTicketClosed( 'http://core.trac.wordpress.org', $ticket_id ) ) {
</span><del>- $this->markTestSkipped( sprintf( 'WordPress Ticket #%d is not fixed', $ticket_id ) . "\n" . $message );
</del><ins>+ $this->markTestSkipped( sprintf( 'WordPress Ticket #%d is not fixed', $ticket_id ) );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Skips the current test if there is an open unit tests ticket with id $ticket_id
</span><span class="cx"> */
</span><del>- function knownUTBug( $ticket_id, $message = '' ) {
</del><ins>+ function knownUTBug( $ticket_id ) {
</ins><span class="cx"> if ( ! WP_TESTS_FORCE_KNOWN_BUGS && ! TracTickets::isTracTicketClosed( 'http://unit-tests.trac.wordpress.org', $ticket_id ) ) {
</span><del>- $this->markTestSkipped( sprintf( 'Unit Tests Ticket #%d is not fixed', $ticket_id ) . "\n" . $message );
</del><ins>+ $this->markTestSkipped( sprintf( 'Unit Tests Ticket #%d is not fixed', $ticket_id ) );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Skips the current test if there is an open plugin ticket with id $ticket_id
</span><span class="cx"> */
</span><del>- function knownPluginBug( $ticket_id, $message = '' ) {
</del><ins>+ function knownPluginBug( $ticket_id ) {
</ins><span class="cx"> if ( ! WP_TESTS_FORCE_KNOWN_BUGS && ! TracTickets::isTracTicketClosed( 'http://plugins.trac.wordpress.org', $ticket_id ) ) {
</span><del>- $this->markTestSkipped( sprintf( 'WordPress Plugin Ticket #%d is not fixed', $ticket_id ) . "\n" . $message );
</del><ins>+ $this->markTestSkipped( sprintf( 'WordPress Plugin Ticket #%d is not fixed', $ticket_id ) );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkteststest_includes_themephp"></a>
<div class="modfile"><h4>Modified: trunk/tests/test_includes_theme.php (895 => 896)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/test_includes_theme.php 2012-07-09 15:37:12 UTC (rev 895)
+++ trunk/tests/test_includes_theme.php 2012-07-09 16:12:47 UTC (rev 896)
</span><span class="lines">@@ -500,7 +500,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * @ticket 11214 looked at how we can reduce the in-memory size even more
</del><ins>+ * Reducing in-memory size further.
+ *
+ * @ticket 11214
</ins><span class="cx"> */
</span><span class="cx"> function test_smaller_storage() {
</span><span class="cx"> $themes = get_themes();
</span></span></pre></div>
<a id="trunkteststest_includes_wpscriptsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/test_includes_wp-scripts.php (895 => 896)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/test_includes_wp-scripts.php 2012-07-09 15:37:12 UTC (rev 895)
+++ trunk/tests/test_includes_wp-scripts.php 2012-07-09 16:12:47 UTC (rev 896)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> /**
</span><span class="cx"> * Test the different protocol references in wp_enqueue_script
</span><span class="cx"> * @global WP_Scripts $wp_scripts
</span><del>- * @ticket 16560 Protocol-relative references
</del><ins>+ * @ticket 16560
</ins><span class="cx"> */
</span><span class="cx"> public function test_protocols() {
</span><span class="cx"> // Init
</span></span></pre></div>
<a id="trunkteststest_includes_wpstylesphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/test_includes_wp-styles.php (895 => 896)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/test_includes_wp-styles.php 2012-07-09 15:37:12 UTC (rev 895)
+++ trunk/tests/test_includes_wp-styles.php 2012-07-09 16:12:47 UTC (rev 896)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> /**
</span><span class="cx"> * Test the different protocol references in wp_enqueue_style
</span><span class="cx"> * @global WP_Styles $wp_styles
</span><del>- * @ticket 16560 Protocol-relative references
</del><ins>+ * @ticket 16560
</ins><span class="cx"> */
</span><span class="cx"> public function test_protocols() {
</span><span class="cx"> // Init
</span></span></pre></div>
<a id="trunkteststest_userphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/test_user.php (895 => 896)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/test_user.php 2012-07-09 15:37:12 UTC (rev 895)
+++ trunk/tests/test_user.php 2012-07-09 16:12:47 UTC (rev 896)
</span><span class="lines">@@ -335,7 +335,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * @ticket 19500 Usermeta cache is not cleared after user deletion
</del><ins>+ * Test that usermeta cache is cleared after user deletion.
+ *
+ * @ticket 19500
</ins><span class="cx"> */
</span><span class="cx"> function test_get_blogs_of_user() {
</span><span class="cx"> // Logged out users don't have blogs.
</span><span class="lines">@@ -354,7 +356,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * @ticket 19500 Usermeta cache is not cleared after user deletion
</del><ins>+ * Test that usermeta cache is cleared after user deletion.
+ *
+ * @ticket 19500
</ins><span class="cx"> */
</span><span class="cx"> function test_is_user_member_of_blog() {
</span><span class="cx"> $old_current = get_current_user_id();
</span></span></pre>
</div>
</div>
</body>
</html>