<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Tests][862] trunk: Remove checkAtLeastPHPVersion() in favor of a once-off.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://unit-tests.trac.wordpress.org/changeset/862">862</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2012-07-02 17:57:04 +0000 (Mon, 02 Jul 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove checkAtLeastPHPVersion() in favor of a once-off. Remove unused and dead knownMUBug. Update URL for knownPluginBug.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwptestcasetest_actionsphp">trunk/wp-testcase/test_actions.php</a></li>
<li><a href="#trunkwptestlibtestcasephp">trunk/wp-testlib/testcase.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwptestcasetest_actionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-testcase/test_actions.php (861 => 862)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-testcase/test_actions.php 2012-07-02 11:00:45 UTC (rev 861)
+++ trunk/wp-testcase/test_actions.php 2012-07-02 17:57:04 UTC (rev 862)
</span><span class="lines">@@ -240,7 +240,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function test_action_closure() {
</span><del>- $this->checkAtLeastPHPVersion('5.3');
</del><ins>+ if ( version_compare( PHP_VERSION, '5.3', '<' ) )
+ $this->markTestSkipped( 'Closures are a PHP 5.3 feature.' );
+
</ins><span class="cx"> $this->knownWPBug(10493);
</span><span class="cx">
</span><span class="cx"> $tag = rand_str();
</span></span></pre></div>
<a id="trunkwptestlibtestcasephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-testlib/testcase.php (861 => 862)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-testlib/testcase.php 2012-07-02 11:00:45 UTC (rev 861)
+++ trunk/wp-testlib/testcase.php 2012-07-02 17:57:04 UTC (rev 862)
</span><span class="lines">@@ -75,12 +75,6 @@
</span><span class="cx"> $this->assertEquals( preg_replace( '/\s*/', '', $expected ), preg_replace( '/\s*/', '', $actual ) );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function checkAtLeastPHPVersion( $version ) {
- if ( version_compare( PHP_VERSION, $version, '<' ) ) {
- $this->markTestSkipped();
- }
- }
-
</del><span class="cx"> function go_to( $url ) {
</span><span class="cx"> // note: the WP and WP_Query classes like to silently fetch parameters
</span><span class="cx"> // from all over the place (globals, GET, etc), which makes it tricky
</span><span class="lines">@@ -143,19 +137,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Skips the current test if there is open WordPress MU ticket with id $ticket_id
- */
- function knownMUBug( $ticket_id ) {
- if ( ! TracTickets::isTracTicketClosed ( 'http://trac.mu.wordpress.org', $ticket_id ) ) {
- $this->markTestSkipped( sprintf( 'WordPress MU Ticket #%d is not fixed', $ticket_id ) );
- }
- }
-
- /**
</del><span class="cx"> * Skips the current test if there is open plugin ticket with id $ticket_id
</span><span class="cx"> */
</span><span class="cx"> function knownPluginBug( $ticket_id ) {
</span><del>- if ( ! TracTickets::isTracTicketClosed( 'http://dev.wp-plugins.org', $ticket_id ) ) {
</del><ins>+ if ( ! TracTickets::isTracTicketClosed( 'http://plugins.trac.wordpress.org', $ticket_id ) ) {
</ins><span class="cx"> $this->markTestSkipped( sprintf( 'WordPress Plugin Ticket #%d is not fixed', $ticket_id ) );
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>