[wp-trac] [WordPress Trac] #54173: Twenty Twenty-One: Social icons

[WordPress Trac]

#54173: Twenty Twenty-One: Social icons
-----------------------------------------+------------------------------
 Reporter:  marco.milone                 |       Owner:  (none)
     Type:  feature request              |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Bundled Theme                |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch 2nd-opinion close  |     Focuses:
-----------------------------------------+------------------------------
Changes (by karmatosed):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion close


Comment:

 > I'm not sure we should automatically replace a visible phone number with
 an icon in Twenty Twenty-One.

 I also don't agree with this approach, particularly when it wasn't the
 case in a theme already and would be a change in expectations. I would
 actually recommend for now closing this for a few reasons:

 - This feels like something would have been decided at the time of the
 theme.
 - No theme is going to solve all cases or needs, even if a default theme.
 - Sometimes having additional functionality is ok in child themes or
 plugins.
 - Other themes have options for those wanting this which can either be
 used as an example in code to take to child theme or swapped to.
 - This theme has had a particular behavior for a while.

 Thank you everyone for your collaboration, in adding the close keyword it
 doesn't mean discussion is stopped it just means we focus on if we should
 do that or there is information to continue to explore.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54173#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform