[wp-trac] [WordPress Trac] #60652: font_dir filter enters an infinite loop if wp_get_upload_dir() is used in the filter callback

[WordPress Trac]

#60652: font_dir filter enters an infinite loop if wp_get_upload_dir() is used in
the filter callback
-------------------------------------------------+-------------------------
 Reporter:  mmaattiiaass                         |       Owner:
                                                 |  peterwilsoncc
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.5
Component:  General                              |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests dev-feedback needs-   |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  has-patch has-unit-tests dev-feedback => has-unit-tests dev-
     feedback needs-patch


Comment:

 Think the inline docs/docblocks need fixing after [57868]. For example: it
 introduces a private function `_wp_filter_font_directory()` but the docs
 have "recommended usage" section? As far as I'm aware it is not
 recommended for plugins and themes to use any of the WP functions marked
 as private.

 In addition thinking there should be a warning that the above function
 will be removed in WP 6.6 (as discussed in the PR) as the implementation
 there will be revised. It is pretty unfortunate that [57868] exposes this
 function (it was a lambda function "hidden" in `handle_font_file_upload()`
 before), but thinking that at least the extenders can be warned not to use
 it as it will go away in 6.6.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60652#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform