[wp-trac] [WordPress Trac] #60815: Regression with theme.json `settings.shadow.defaultPresets`

[WordPress Trac]

#60815: Regression with theme.json `settings.shadow.defaultPresets`
----------------------------------------------------+---------------------
 Reporter:  ajlende                                 |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.5
Component:  Themes                                  |     Version:  trunk
 Severity:  normal                                  |  Resolution:
 Keywords:  has-patch needs-testing has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by poena):

 Is this summary accurate?


 **If we don't do anything, then:**
 1) Neither classic themes or block themes will have shadows enabled by
 default.
   - This is a change from 6.4.3 where block themes had shadows by default
 for buttons in the (global) Styles setting sidebar.
   - This is a problem because the defaults should not change without a
 theme.json version change(?)
 2) There is a problem in any themes that has a theme.json, when a
 developer registers a custom shadow presets with the same slug as the core
 preset.
 3) Classic themes without theme.json can not set their own presets.
 4) Classic themes without theme.json can opt-in with the appearance-tools
 theme support.
 5) No action is required today for the bundled themes.


 **If we merge 6303, then:**
 1) Both classic themes and block themes will have shadows enabled by
 default.
 2) The problem with the duplicate slugs would be solved(?)
 3) Any themes can opt out or set custom presets via theme.json.
 4) Classic themes without theme.json can not set their own presets (this
 will be fixed in 6.6).
 5) Classic themes without theme.json can not opt-out (this will be fixed
 in 6.6).
 6) The shadows must be tested with the classic bundled themes. There
 ''should'' not be conflicts but this needs to be confirmed with testing.

 **If we merge 6295, then:**
 1) Both classic themes and block themes will have shadows enabled by
 default.
 2) The problem with the duplicate slugs would be solved(?)
 3) Any themes can opt out or set custom presets via theme.json.
 4) Classic themes without theme.json can set their own presets.
 5) Classic themes without theme.json can opt-out.
 6) The shadows must be tested with the classic bundled themes. There
 ''should'' not be conflicts but this needs to be confirmed with testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60815#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform