[wp-trac] [WordPress Trac] #60815: Regression with theme.json `settings.shadow.defaultPresets`

WordPress Trac noreply at wordpress.org
Wed Mar 20 19:34:53 UTC 2024


#60815: Regression with theme.json `settings.shadow.defaultPresets`
-------------------------------------------------+-------------------------
 Reporter:  ajlende                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Themes                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by ajlende):

 > I don't feel comfortable with making yet another change here that isn't
 a simple revert.

 The one line change in [https://github.com/WordPress/wordpress-
 develop/pull/6295/files#diff-
 0a35f8ff88e18fde4294ab337d101751ba8777ff270dabb7d25d31627ff015f9
 theme.json] is sufficient to fix the regression.

 The intention of setting `shadow.defaultPresets` to `false` was to allow
 classic themes to opt-in to them, and the rest of the changes that are
 being discussed are to support that the correct way.

 If we only include the one line change, the effect will be that classic
 themes don't have the option to configure shadows and the default shadows
 will appear in the block editor for classic themes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60815#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list