[wp-trac] [WordPress Trac] #60800: Twenty Twenty-One: prevent PHP 8 fatal error from non-string in $tags_list

WordPress Trac noreply at wordpress.org
Mon Mar 18 18:05:23 UTC 2024


#60800: Twenty Twenty-One: prevent PHP 8 fatal error from non-string in $tags_list
----------------------------------------+---------------------
 Reporter:  josephscott                 |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  6.6
Component:  Bundled Theme               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+---------------------

Comment (by sabernhardt):

 Every bundled theme before Twenty Twenty-One included the `!
 is_wp_error()` condition when using `get_the_tag_list()` (Twenty Fourteen
 and Twenty Twenty have `the_tags()` instead).

 - Twenty Ten's [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyten/functions.php?rev=57850&marks=673,675#L675
 twentyten_posted_in() function] and the
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyten/loop.php?rev=57850&marks=181-182#L182 loop
 template]
 - Twenty Eleven's [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyeleven/content.php?rev=57850&marks=74,76#L76 main
 content template] (plus [https://core.trac.wordpress.org/browser/trunk/src
 /wp-content/themes/twentyeleven/content-
 featured.php?rev=57850&marks=35,37#L37 content-featured],
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyeleven/content-gallery.php?rev=57850&marks=89,91#L91
 content-gallery], [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyeleven/content-image.php?rev=57850&marks=71,73#L73
 content-image], [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyeleven/content-quote.php?rev=57850&marks=65,67#L67
 content-quote], and [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyeleven/content-single.php?rev=57850&marks=38,40#L40
 content-single])
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentytwelve/functions.php?rev=57850&marks=524,542#L542
 twentytwelve_entry_meta]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentythirteen/functions.php?rev=57850&marks=577-578#L578
 twentythirteen_entry_meta]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyfifteen/inc/template-
 tags.php?rev=57850&marks=118-119#L119 twentyfifteen_entry_meta]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentysixteen/inc/template-
 tags.php?rev=57850&marks=116-117#L117 twentysixteen_entry_taxonomies]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentyseventeen/inc/template-
 tags.php?rev=57850&marks=71,91#L91 twentyseventeen_entry_footer]
 - [https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/inc/template-
 tags.php?rev=57850&marks=98-99#L99 twentynineteen_entry_footer]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60800#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list