[wp-trac] [WordPress Trac] #57774: Add some initial PHPUnit tests for `WP_Filesystem_Direct`

[WordPress Trac]

#57774: Add some initial PHPUnit tests for `WP_Filesystem_Direct`
---------------------------------------------+-----------------------------
 Reporter:  costdev                          |       Owner:  hellofromTonya
     Type:  task (blessed)                   |      Status:  reopened
 Priority:  normal                           |   Milestone:  6.5
Component:  Build/Test Tools                 |     Version:  2.5
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by swissspidy):

 There's a third issue I just noticed:

 {{{
 Tests_Filesystem_WpFilesystemDirect_Mkdir::test_should_set_chmod
 The permissions are incorrect.
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -'0644'
 +'0755'

 /home/wptestrunner/site/public_html/wp-test-
 runner/tests/phpunit/tests/filesystem/wpFilesystemDirect/mkdir.php:133
 }}}

 See https://make.wordpress.org/hosting/test-
 results/r57848/wpmudevbot-r57848/

 Maybe that host sets `FS_CHMOD_DIR` to something custom?

 After [https://github.com/WordPress/wordpress-develop/pull/6286 my PR],
 this test is the last one with an `is_windows()` check. Would be good if
 we could get rid of this env-specific check and maybe rely on comparing
 with `FS_CHMOD_DIR` instead.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57774#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform