[wp-trac] [WordPress Trac] #60633: Shadow: add shadow control to appearanceTools opt-ins

WordPress Trac noreply at wordpress.org
Tue Mar 12 11:19:16 UTC 2024


#60633: Shadow: add shadow control to appearanceTools opt-ins
---------------------------------------------+-------------------------
 Reporter:  madhudollu                       |       Owner:  swissspidy
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  6.5
Component:  Editor                           |     Version:
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-------------------------

Comment (by wildworks):

 I noticed that the Gutenberg PR was not fully backported. In the original
 PR, `defaultPresets` was changed from `true` to `false` in the default
 `theme.json`:

 https://github.com/WordPress/gutenberg/pull/58766/files#diff-
 ba57fd27dc15a6079df31427f442f760cbe4035a941cfb1a4763c7cf90766b15R194

 But [57717] does not include any `theme.json` changes, so `defaultPresets`
 remains `true`:

 https://github.com/WordPress/wordpress-
 develop/blob/697bd4efd63941847e53e43daa3a23cd81c08cd3/src/wp-
 includes/theme.json#L194

 This means that in the Classic theme, blocks are inadvertently provided
 with shadow control by default.

 I think this issue should be resolved in WP6.5, but if I want to submit a
 patch/PR, should I check out the `trunk` branch of `wordpress-develop`?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60633#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list