[wp-trac] [WordPress Trac] #60501: Plugin card dependencies notice and image can overlap.

[WordPress Trac]

#60501: Plugin card dependencies notice and image can overlap.
--------------------------+-----------------------
 Reporter:  costdev       |       Owner:  costdev
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  6.5
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by euthelup):

 Replying to [comment:7 desrosj]:
 > It looks like [attachment:"60501-2.diff"] does fix this issue. I don't
 love having to add a different class for this. I could have sworn there
 was something similar already, but haven't been able to find it.

 I think that popular CSS frameworks use classes like `pull-down` or `pull-
 bottom` for features like this but I've never seen one in WordPress.

 > Something else that came to mind looking at this. Is there a reason the
 standard admin notice classes would not work for this? That would avoid
 having to include specific styles for this one of notice class.

 Just to be sure, you are referring to `.notice .notice-alt .notice-info`
 right?

 Replying to [comment:9 swissspidy]:
 > Instead of adding a new CSS class, can't we just style the existing
 `.plugin-dependencies` class?
 >
 > {{{
 > .plugin-card .plugin-dependencies {
 >     background-color: #e5f5fa;
 >     border-left: 3px solid #72aee6;
 >     padding: 15px;
 >     margin: auto 20px 20px;
 > }
 > }}}
 >
 > Though I have to say the class name `plugin-dependencies` is very
 generic.
 >
 > So +1 to reusing existing admin notice classes & styling where possible.

 TBH I've added `plugin-card-center` just for the sake of consistency with
 the other two elements on the same level `plugin-card-top` and `plugin-
 card-bottom`.
 If you all feel comfortable with only having `plugin-dependencies` div
 there I'm ok with it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60501#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform