[wp-trac] [WordPress Trac] #60524: Cropping site icon should preserve attachment properties

[WordPress Trac]

#60524: Cropping site icon should preserve attachment properties
---------------------------------------------+----------------------------
 Reporter:  afercia                          |       Owner:  joedolson
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  6.5
Component:  Media                            |     Version:
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  accessibility
---------------------------------------------+----------------------------
Changes (by joedolson):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57755" 57755]:
 {{{
 #!CommitTicketReference repository="" revision="57755"
 Media: Accessibility: Copy attachment properties on site icon crop.

 Add parity between site icon, custom header, and default image crop
 behaviors. [53027] fixed a bug where alt text and caption were not copied
 on custom headers, but did not apply that change in any other context.

 Deprecate the `create_attachment_object` method in the `Wp_Site_Icon` and
 `Custom_Image_Header` classes and replace that functionality with the new
 function `wp_copy_parent_attachment_properties()` to improve consistency.

 Props afercia, rcreators, jorbin, joedolson, huzaifaalmesbah, shailu25,
 swissspidy, mukesh27.
 Fixes #60524.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60524#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform