[wp-trac] [WordPress Trac] #60374: Twenty Sixteen: Navigation block inherits colors from button styles

[WordPress Trac]

#60374: Twenty Sixteen: Navigation block inherits colors from button styles
-----------------------------------+------------------------------
 Reporter:  poena                  |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Bundled Theme          |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch 2nd-opinion


Comment:

 The background, padding, outline-offset and letter-spacing needed to be
 updated for any button in the Navigation block. I also removed the margin
 on the submenu, making it work with LTR or RTL directions (without `.rtl`
 class). The open modal also need padding because the global CSS variables
 are not defined (likely the case in //any// classic theme).

 Some of these styles should be changed in the editor's block styles
 instead of—or in addition to—theme edits.

 On the other hand, maybe the Navigation block should not be supported
 inside the post content of a classic theme. It is not available in
 Widgets.

 Issues in other bundled themes:
 - Twenty Thirteen has dark text on an orange gradient background in all
 states plus an extra top border on `:active`.
 - Twenty Fourteen has a green background with dark text on hover/focus.
 - Twenty Fifteen and Twenty Seventeen have a medium gray background with
 dark text on hover/focus.
 - See #59924 for Twenty Nineteen.
 - Twenty Twenty-One does not have contrast problems, but the caret looks
 odd inside the button and the button's negative `outline-offset` makes it
 cover text.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60374#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform