[wp-trac] [WordPress Trac] #60309: Indirect modification of overloaded property WP_Block_Type::$variations has no effect

[WordPress Trac]

#60309: Indirect modification of overloaded property WP_Block_Type::$variations has
no effect
--------------------------------------+------------------------
 Reporter:  thekt12                   |       Owner:  thekt12
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:
Component:  General                   |     Version:  trunk
 Severity:  blocker                   |  Resolution:  duplicate
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------
Changes (by joemcgill):

 * status:  assigned => closed
 * resolution:   => duplicate
 * milestone:  Awaiting Review =>


Comment:

 The PHPUnit failures in the Gutenberg repo have been resolved via
 https://github.com/WordPress/gutenberg/pull/58090. I'm going to close this
 ticket and we can continue any other back-compat concerns with the changes
 to block variations in #59969 so everything stays in one place.

 @thekt12 I think https://github.com/WordPress/wordpress-develop/pull/5915
 still has merit to explore further, do you mind updating the PR
 description to point to #59969 instead? I'm still not confident that we
 want to support this type of direct modification of overloaded properties,
 but if we can find an easy solution that makes the class more robust, I'm
 not opposed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60309#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform