[wp-trac] [WordPress Trac] #59969: Conditional loading `build_template_part_block_variations` for performance improvement

[WordPress Trac]

#59969: Conditional loading `build_template_part_block_variations` for performance
improvement
--------------------------------------+--------------------------
 Reporter:  thekt12                   |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.5
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch needs-dev-note  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by joemcgill):

 Replying to [comment:59 ellatrix]:
 > Correct me if I'm wrong, but didn't this change a public API? What
 happened to back compat?
 >

 As I've looked into the failures during the first part of my day today, it
 does seem to me like the PHPUnit issues in the Gutenberg repo are a result
 of the way those tests are written and not with a true back-compat break
 caused by the changes here. I'm working on a fix for the GB tests now, but
 we may need to temporarily disable some tests in the
 `Block_Navigation_Link_Variations_Test` class to unblock others.

 I do think there is a legitimate question about what kinds of
 modifications to variations should be supported for registered blocks once
 the variations data has already been accessed, but that seems like a
 separate issue to what this issue is trying to solve.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59969#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform