[wp-trac] [WordPress Trac] #59969: Conditional loading `build_template_part_block_variations` for performance improvement

WordPress Trac noreply at wordpress.org
Mon Jan 22 08:57:54 UTC 2024


#59969: Conditional loading `build_template_part_block_variations` for performance
improvement
--------------------------------------+--------------------------
 Reporter:  thekt12                   |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  6.5
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by gaambo):

 Replying to [comment:13 gaambo]:
 > In #59906 (based on https://github.com/WordPress/gutenberg/pull/54801,
 https://github.com/WordPress/gutenberg/pull/56100 and
 https://github.com/WordPress/gutenberg/pull/56080) I added variations for
 the post-term and navigation link block. Both were mentioned in comment:11

 Noting again that the code from my PRs in Gutenberg - once GB is merged
 into core - will probably fail as well, since I'm adding variations
 manually (via `->variations[]`) as well.
 I don't think using the `variations_callback` is viable in these cases,
 since when the callback is called, I still don't know if all taxonomies
 and post types are registered.
 How should we handle this - in #59906 for merging the PHP changes into
 core, should I open a seperate issue in Gutenberg as a follow up - what's
 the best way here?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59969#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list