[wp-trac] [WordPress Trac] #49931: Twenty Nineteen: Group color styles prevent custom colors

[WordPress Trac]

#49931: Twenty Nineteen: Group color styles prevent custom colors
-------------------------------------+-----------------------
 Reporter:  Joen                     |       Owner:  poena
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  6.5
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  css
-------------------------------------+-----------------------
Changes (by poena):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 While testing on WordPress 6.4.2 and current trunk I found that when a
 container block has a background color from the palette, the text color
 works on the front but not in the editor.

 Because of that I have submitted a patch that only updates the style-
 editor.scss file.
 With the patch, the default contrasting text color is only applied if the
 user has not selected a text color.

 == Testing Instructions


 === Steps to Test
 1. Apply the patch
 2. Build the updated stylsheets by running the npm command "npm run build"
 3. Go to the block editor.
 4. Add a group block with a paragraph. Select the group and add the blue
 background color and any text color.
 5. Confirm that the colors work in the editor and the front.
 6. Select the paragraph and add a text color. Confirm that this text color
 is used, and not the text color that was set on the group: It should
 override the group colors.
 7. Now repeat step 4-6 with the different background colors: blue, dark
 blue, dark grey, light grey, and white.
 8. Finally, open the Customizer, open the color panel, and change the
 color from default to custom.
 Confirm that the colors swork in the editor and the front.

 Bonus: Try with other blocks such as columns and media & text.



 === Expected Results
 The text color that the user chooses shows in both the editor and the
 front,
 no matter what the background color is.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49931#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform