[wp-trac] [WordPress Trac] #60227: HTML API: Add external test suite

WordPress Trac noreply at wordpress.org
Wed Jan 17 00:58:23 UTC 2024


#60227: HTML API: Add external test suite
--------------------------------------+------------------------------
 Reporter:  jonsurrell                |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  HTML API                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by jorbin):

 This is an intrigruing idea. I have a few large concerns/things I think
 need to be resolved and some smaller ones:

 1. How do we keep this updated? Could this be set as an SVN external or be
 included in some other way to ensure it stays updated besides a person
 manually checking if there are new commits?
 2. Do we have any idea what the long term plans are for this project? I
 see that the majority of the projects from this github organization seem
 to be inactive or abandon. Additionally, I don't see any sort of code of
 conduct, do we know if this project is one who's values align with
 WordPress?
 3. What's the reasoning besides skipping the tests that don't expect empty
 head? This is leading to 500+ skipped tests.
 4. It would be good to get the tests passing and the coding standard
 issues resolved before doing a full review
 5. nitpic, but the naming feels a bit cumbersome.
 `Tests_HtmlApi_WpHtmlProcessorHtml5lib::test_external_html5lib` just feels
 long.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60227#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list