[wp-trac] [WordPress Trac] #59930: Problems pulling relevant MySQL Docker container

[WordPress Trac]

#59930: Problems pulling relevant MySQL Docker container
------------------------------+---------------------
 Reporter:  desrosj           |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  6.5
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------
Changes (by desrosj):

 * keywords:  has-patch commit => has-patch


Comment:

 I've been thinking about this the last few weeks, and the more I mull it
 over the more I lean towards using a solution similar to [attachment
 :"bump-mysql-to-8-2.diff"] instead of [attachment:"59930.diff"].

 By adding `platform: linux/amd64` to the compose file, we're applying a
 bandaid for old versions of MySQL that potentially has a negative impact
 for contributors using more modern versions (8.0+), or skipping MySQL
 entirely and using MariaDB. Instead of doing this, I think we should
 increase the default version used from 5.7 to 8.0. Versions 8.1 and 8.2
 are "innovation releases", and a larger conversation needs to be had
 around how we support these versions. See #59779 for more info.

 Updating the default version is a change that should have been done by now
 and is overdue, in my opinion.

 For the second part (solving the problem when contributors choose to run
 older MySQL versions locally), we could take one of two approaches:

 - Add documentation to the README file that notes contributors using Apple
 Silicone machines will need to have a `docker-compose.override.yml` when
 using MySQL 5.7 or lower. An example file can also be included as a
 snippet.
 - Add `platform: ${LOCAL_ARCH_TYPE}` to the `docker-compose.yml` file and
 dynamically set the value of this environment variable based on the actual
 architecture in use and the values provided for `LOCAL_DB_TYPE` and
 `LOCAL_DB_VERSION`. Something like when `LOCAL_DB_TYPE == 'mysql' &&
 LOCAL_DB_VERSION <= 5.7 && architecture == 'arm64'`, use `linux/amd64`
 instead.

 We don't currently run automated testing on non-Linux images in GitHub
 Action, so the second option would only be required when contributors are
 running the local environment on ARM.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59930#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform