[wp-trac] [WordPress Trac] #60290: Changeset #56635 breaks template loading in multisite network using switch_to_blog()

WordPress Trac noreply at wordpress.org
Wed Feb 28 16:35:17 UTC 2024


#60290: Changeset #56635 breaks template loading in multisite network using
switch_to_blog()
-------------------------------------------------+-------------------------
 Reporter:  metropolis_john                      |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4.4
Component:  Themes                               |     Version:  6.4.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests changes-    |     Focuses:
  requested fixed-major                          |  performance
-------------------------------------------------+-------------------------
Changes (by joemcgill):

 * keywords:  has-patch has-unit-tests changes-requested 2nd-opinion => has-
     patch has-unit-tests changes-requested fixed-major
 * milestone:  6.5 => 6.4.4


Comment:

 @manfcarlo Thank you for the attention that you've given to this issue and
 for sharing your concerns. I can tell you that marking this issue as a
 `wontfix` for the reasons you have raised throughout this ticket were
 seriously considered. After feedback from many longstanding contributors
 and component maintainers, including @swissspidy and @jeremyfelt, I
 decided to fix this bug.

 The `get_theme_mod` issues that you have raised here seem valid, but have
 been existing issues for a long time, except for WP 6.4.2+ when this issue
 was first introduced due to [57129]. Based on your response, it sounds
 like your concern is theoretical rather than an issue that is affecting
 your project, whereas this issue was opened to address a change in
 behavior that was adversely effecting real sites. Now that this issue is
 solved, I'd encourage you to open a new issue to address the issues you've
 described here.

 I agree with you that we should consider backporting this fix to 6.4 as
 well, so I've moved this to the 6.4.4 milestone for consideration, but at
 this time no other maintenance releases are planned for 6.4. If another
 maintenance release does not happen before 6.5, this should be closed as
 fixed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60290#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list