[wp-trac] [WordPress Trac] #60620: Twenty Twenty-Four: Remove pattern from home template to improve performance

WordPress Trac noreply at wordpress.org
Fri Feb 23 10:11:54 UTC 2024


#60620: Twenty Twenty-Four: Remove pattern from home template to improve
performance
---------------------------+------------------------------
 Reporter:  onemaggie      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Description changed by onemaggie:

Old description:

> This PR removes the pattern from the home template and instead replaces
> it directly with its contents.
>
> This was introduced in [this
> PR](https://github.com/WordPress/twentytwentyfour/pull/486). Creating the
> pattern was needed to solve what the PR was stating (we need the Home
> Business pattern to show on the template replacement flows) but we don't
> need to use it in the template, and the code repetition (which is minor)
> is better than having to do a an extra pattern replacement.
>
> To test this PR, check that the home page is unchanged and that creating
> a new template still shows the home page pattern (by creating a template
> for the front page, for example)

New description:

 This PR removes the pattern from the home template and instead replaces it
 directly with its contents.

 This was introduced in
 [https://github.com/WordPress/twentytwentyfour/pull/486 this PR]. Creating
 the pattern was needed to solve what the PR was stating (we need the Home
 Business pattern to show on the template replacement flows) but we don't
 need to use it in the template, and the code repetition (which is minor)
 is better than having to do a an extra pattern replacement.

 To test this PR, check that the home page is unchanged and that creating a
 new template still shows the home page pattern (by creating a template for
 the front page, for example)

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60620#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list