[wp-trac] [WordPress Trac] #58087: Fix the 'data' dynamic property in WP_Term

[WordPress Trac]

#58087: Fix the 'data' dynamic property in WP_Term
-------------------------------------+-------------------------------------
 Reporter:  antonvlasenko            |       Owner:  hellofromTonya
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.6
Component:  Taxonomy                 |     Version:  6.3
 Severity:  minor                    |  Resolution:
 Keywords:  php82 needs-testing      |     Focuses:  coding-standards, php-
  has-patch has-unit-tests changes-  |  compatibility
  requested early                    |
-------------------------------------+-------------------------------------
Changes (by hellofromTonya):

 * keywords:  php82 needs-testing has-patch has-unit-tests => php82 needs-
     testing has-patch has-unit-tests changes-requested early
 * status:  reviewing => accepted
 * milestone:  6.5 => 6.6


Comment:

 In exploring the fix strategy in [https://github.com/WordPress/wordpress-
 develop/pull/6163 PR 6163], discovered a few things that need
 consideration:

 * The `WP_Term::filter` property should not be included in
 `wp_update_term()`. Notice it's not part of the properties in `data`.
 * The existing tests are adding and/or testing for other dynamic
 properties, including `link` and `errors`. Removing the getter causes
 these to fail.
 * The test coverage needs review to ensure there's enough coverage to
 validate these changes.

 This work needs more time and likely a longer soak time (i.e. `early`
 alpha) to discover potentially other scenarios especially in the wild.

 Moving this to 6.6 but will continue working on to land in early alpha.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58087#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform