[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
---------------------------------------+-----------------------
 Reporter:  jameskoster                |       Owner:  jorbin
     Type:  task (blessed)             |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.5
Component:  General                    |     Version:  5.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------

Comment (by jameskoster):

 > Questions about how specific to follow your code pen and if the intent
 is to be using highly specific measurements (such as 9.824px for a border
 radius) and multiple box shadows

 The measurements for radius are based on Apple home icons. It's probably
 fine to round up, though I don't see a need? Of course, these values are
 subject to change, but that's the nature of using a preview, and why I'd
 continue to advocate not doing so.

 I don't see an issue with multiple box shadow values, but if that's going
 to be a problem then maybe omit shadows altogether and increase blur on
 the backdrop.

 > It seems like it could cause more confusion then benefit in those
 situations

 That's good feedback. I've made an updated codepen
 (https://codepen.io/jameskoster/pen/abMrYmX) that removes the shadows and
 improves the appearance when a solid-color site icon is used. This starts
 to feel like optimising for edge cases, but if we're 100% set on the
 preview then these things must be considered.

 A separate note on the code, ideally all the greys use css variables
 (assuming those are available outside of Gutenberg) rather than being
 hard-coded.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:108>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform