[wp-trac] [WordPress Trac] #60524: Cropping site icon should preserve attachment properties

[WordPress Trac]

#60524: Cropping site icon should preserve attachment properties
-----------------------------------+----------------------------
 Reporter:  afercia                |       Owner:  rcreators
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  6.5
Component:  Media                  |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  accessibility
-----------------------------------+----------------------------
Changes (by joedolson):

 * keywords:  has-patch needs-testing => has-patch 2nd-opinion


Comment:

 I think this looks good. However, I think it may be worthwhile to remove
 the `create_attachment_object` method. I looked over the directory
 results, and there are really only two plugins and one theme using this;
 everything else is people committing vendor directories, build tools, etc.
 Only one of those plugins has a significant installation base, and I think
 it's a pretty low bar to change this rather than keep an unused method in
 core.

 But I'd appreciate second opinions on that; it would be removing core
 methods and breaking backwards compatibility, but only on a very small
 scale.

 I think this is good for commit as is, just would like a second opinion
 about whether or not to remove the unused method.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60524#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform