[wp-trac] [WordPress Trac] #31352: Media icons are not retina friendly

WordPress Trac noreply at wordpress.org
Wed Feb 21 19:25:36 UTC 2024


#31352: Media icons are not retina friendly
---------------------------------------------+-----------------------------
 Reporter:  iseulde                          |       Owner:  joedolson
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  6.5
Component:  Media                            |     Version:  3.9
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  ui,
                                             |  administration
---------------------------------------------+-----------------------------
Changes (by joedolson):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57687" 57687]:
 {{{
 #!CommitTicketReference repository="" revision="57687"
 Media: Ensure `wp_mine_type_icon()` returns expected file type.

 Add an argument to `wp_mime_type_icon()` to control the file type
 returned. Following [57638], there are two file formats in the media icons
 directory. Different systems would pull up different files by default
 dependent on the order loaded into the cached array, causing intermittent
 test failures and unpredictable behavior.

 Function update allows core usages to always return the `.svg` while
 maintaining backwards compatibility for any extended usage that expects a
 `.png`. Follow up to [57638].

 Also handles a missed case in media list view.

 Props SergeyBiryukov, sabernhardt, joedolson, antpb.
 Fixes #31352.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31352#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list