[wp-trac] [WordPress Trac] #59655: Tests: Reduce usage of assertEquals for 6.5

WordPress Trac noreply at wordpress.org
Sat Feb 17 16:32:53 UTC 2024


#59655: Tests: Reduce usage of assertEquals for 6.5
--------------------------------------+---------------------
 Reporter:  hellofromTonya            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.5
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"57650" 57650]:
 {{{
 #!CommitTicketReference repository="" revision="57650"
 Tests: Use `assertSame()` in `get_comment_pages_count()` tests.

 This ensures that not only the return values match the expected results,
 but also that their type is the same.

 Going forward, stricter type checking by using `assertSame()` should
 generally be preferred to `assertEquals()` where appropriate, to make the
 tests more reliable.

 Follow-up to [27055], [48937], [54402], [57244], [57648].

 Props costdev.
 See #58683, #59655.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59655#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list