[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
---------------------------------------+-----------------------
 Reporter:  jameskoster                |       Owner:  jorbin
     Type:  task (blessed)             |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.5
Component:  General                    |     Version:  5.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------

Comment (by afercia):

 > I think removing this was premature and it would be best to add it back
 and use it for aria-describedby since that will be consistent with the
 rest of the experience on this page.

 I'm not sure you are fully getting how `aria-describedby` is meant to be
 used. Usually, we use it to associate an input field to a description. In
 this case, there's no input field. There's buttons that get dynamically
 hidden. Associating the 'choose' button to the descriptions is technically
 possible but not recommended, as the button gets hidden when an image is
 set. I don't think we should use `aria-describedby` in this UI and thus
 the IDs are unnecessary. They weren't used anyways in the original commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:85>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform