[wp-trac] [WordPress Trac] #59810: Global styles revisions: add route for single styles revisions

WordPress Trac noreply at wordpress.org
Wed Feb 14 00:44:22 UTC 2024


#59810: Global styles revisions: add route for single styles revisions
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:
                                                 |  youknowriad
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.5
Component:  General                              |     Version:  6.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:  rest-api
  merge add-to-field-guide                       |
-------------------------------------------------+-------------------------

Comment (by ramonopoly):

 > Can you update the status here?


 If https://github.com/WordPress/wordpress-develop/pull/6105 is committed
 in a subsequent round of WP 6.5 Beta, then we can close this ticket.

 As I understand it, the outstanding issue is as follows:

 As mentioned in the
 [https://core.trac.wordpress.org/ticket/59810#comment:8 comment above],
 there was a fix to the `get_item` method of `WP_REST_Revisions_Controller`
 to prevent returning a revision whose parent ID property does not match
 the parent ID.

 Here's the relevant Github PR:

 https://github.com/WordPress/wordpress-develop/pull/5655/files#diff-
 17ea2a95dc40f1f9804ed19a22d88a110f88920ca49e503860d00e5f34aef0b2R395


 This fix has not yet been ported to
 `WP_REST_Global_Styles_Revisions_Controller`

 https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes
 /rest-api/endpoints/class-wp-rest-global-styles-revisions-
 controller.php#L279

 I will prepare a follow up PR to do this in the event that
 https://github.com/WordPress/wordpress-develop/pull/6105 is not committed
 for WordPress 6.5.

 Thank you!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59810#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list