[wp-trac] [WordPress Trac] #60131: Global styles controllers: extend classes with WP_REST_Posts_Controller and WP_REST_Revisions_Controller

[WordPress Trac]

#60131: Global styles controllers: extend classes with WP_REST_Posts_Controller and
WP_REST_Revisions_Controller
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.5
Component:  REST API                             |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 @ramonopoly To update.

 This ticket was committed in [57624] but was revert as part of beta 1
 release, becuase unit tests are failing [57628].

 The reason it was reverted, as the signuare of the
 `WP_REST_Global_Styles_Revisions_Controller` class found in core did not
 match the one found in gutenberg. As the constuctor and properties were
 different, this resulted in a PHP error, resulting in the e2e fail.

 I have reopened the PR and added a [https://github.com/WordPress
 /wordpress-develop/commit/95db1e9e668861c48ed974dd6562c8d1c63adf7d fix].
 This fix is really simple and makes the class backwards compatible. Need
 to reviews and testing if we want to get this committed in beta 2.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60131#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform