[wp-trac] [WordPress Trac] #59782: PHP deprecation error in WP_Image_Editor_Imagick

WordPress Trac noreply at wordpress.org
Sun Feb 4 07:41:25 UTC 2024


#59782: PHP deprecation error in WP_Image_Editor_Imagick
-----------------------------+--------------------------------
 Reporter:  skithund         |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Media            |     Version:  3.5
 Severity:  normal           |  Resolution:
 Keywords:  php81 has-patch  |     Focuses:  php-compatibility
-----------------------------+--------------------------------

Comment (by mai21):

 - Reproducible using the steps mentioned here
 https://core.trac.wordpress.org/ticket/59782#comment:3

 - Tested the patch on WP 6.4.3 and 6.5-alpha-57529, with PHP 8.3.1, and
 can confirm that it's fixed.

 **Steps**
 1- Go to /wp-admin/media-new.php and upload an image
 2- "Edit" the image
 3- Then do a crop with the mouse and "Apply crop"
 4- See the Implicit conversion from float in the debug log

 **With Patch**
 No 'PHP Deprecated:  Implicit conversion from float xxx.xx' in debug.log



 **General note**
 After cropping the image, the size displayed on the image edit page is
 still that of the original image, not the newly generated image. However,
 if the image was used on a page, the new size will be used. => **Not
 related to the patch, not sure if we have a ticket about this**.

 General note => Steps:
 1- Upload an image
 2- Open media library -> edit image
 3- Notice the file size displayed on image data at the most right
 4- Crop the image and click apply crop then save edits
 5- Click the update button
 6- Notice the file size => didn't change while the dimensions changed. (if
 we downloaded the new file, the size is different than that displayed on
 the edit image page)

 Expected:
 File size is updated as same as dimensions since the size is already
 changed

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59782#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list