[wp-trac] [WordPress Trac] #60706: Tests: Reduce usage of assertEquals for 6.6

WordPress Trac noreply at wordpress.org
Mon Apr 29 15:38:54 UTC 2024


#60706: Tests: Reduce usage of assertEquals for 6.6
--------------------------------------+---------------------
 Reporter:  SergeyBiryukov            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.6
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"58054" 58054]:
 {{{
 #!CommitTicketReference repository="" revision="58054"
 Tests: Use `assertSame()` in `WP_Comment::get_instance()` tests.

 This ensures that not only the return values match the expected results,
 but also that their type is the same.

 Going forward, stricter type checking by using `assertSame()` should
 generally be preferred to `assertEquals()` where appropriate, to make the
 tests more reliable.

 Follow-up to [38381].

 Props costdev.
 See #60706.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60706#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list