[wp-trac] [WordPress Trac] #60305: Ensure that `Tests_Theme_wpThemeJson::test_set_spacing_sizes_should_detect_invalid_spacing_scale` is compatible with PHPUnit 10

[WordPress Trac]

#60305: Ensure that
`Tests_Theme_wpThemeJson::test_set_spacing_sizes_should_detect_invalid_spacing_scale`
is compatible with PHPUnit 10
-------------------------------------------------+-------------------------
 Reporter:  antonvlasenko                        |       Owner:
                                                 |  youknowriad
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.5
Component:  Editor                               |     Version:  6.5
 Severity:  minor                                |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by antonvlasenko):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests dev-
     feedback


Comment:

 @jorbin I believe it might be worth considering a revert of
 https://core.trac.wordpress.org/changeset/57361, as it appears that its
 code does not get executed.
 The handler is already being cleaned up within the new error handler
 itself:
 {{{
                 set_error_handler(
                         static function ( $errno, $errstr ) {
                                 restore_error_handler(); // <-- This is
 where it's cleared up.
                                 throw new Exception( $errstr, $errno );
                         },
                         E_ALL
                 );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60305#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform