[wp-trac] [WordPress Trac] #60961: WP_HTML_Processor::is_void() is missing deprecated tags

WordPress Trac noreply at wordpress.org
Mon Apr 8 17:33:59 UTC 2024


#60961: WP_HTML_Processor::is_void() is missing deprecated tags
--------------------------+------------------------------
 Reporter:  westonruter   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  HTML API      |     Version:  6.4
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Description changed by westonruter:

Old description:

> In a [https://github.com/WordPress/performance/pull/1115 pull request] to
> reuse `WP_HTML_Processor::is_void()` instead of my manual list of void
> tags, I noticed that unit tests were failing for tests involving the
> `BASEFONT`, `BGSOUND`, `KEYGEN,`, and `PARAM` tags. These deprecated/non-
> nonstandard tags are treated as void by the browser, and yet they are not
> currently included in `WP_HTML_Processor::is_void()`.
>
> Including `BASEFONT`, `BGSOUND`, and `KEYGEN` may not be warranted
> considering that none of these are seen in HTTP Archive (see
> [https://docs.google.com/spreadsheets/d/1grkd2_1xSV3jvNK6ucRQ0OL1HmGTsScHuwA8GZuRLHU/edit#gid=571472591
> sheet]). Nevertheless, `PARAM` is present, even though it rounds to 0.0%
> of pages.

New description:

 In a [https://github.com/WordPress/performance/pull/1115 pull request] to
 reuse `WP_HTML_Processor::is_void()` instead of my manual list of void
 tags, I noticed that unit tests were failing for tests involving the
 `BASEFONT`, `BGSOUND`, `FRAME`, `KEYGEN,`, and `PARAM` tags. These
 deprecated/non-nonstandard tags are treated as void by the browser, and
 yet they are not currently included in `WP_HTML_Processor::is_void()`.

 Including `BASEFONT`, `BGSOUND`, and `KEYGEN` may not be warranted
 considering that none of these are seen in HTTP Archive (see
 [https://docs.google.com/spreadsheets/d/1grkd2_1xSV3jvNK6ucRQ0OL1HmGTsScHuwA8GZuRLHU/edit#gid=571472591
 sheet]). Nevertheless, `FRAME` and `PARAM` are present, even though they
 round to 0.0% of pages.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60961#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list