[wp-trac] [WordPress Trac] #50446: Twenty Fifteen: Regression in updated sticky sidebar code

[WordPress Trac]

#50446: Twenty Fifteen: Regression in updated sticky sidebar code
---------------------------+------------------------------
 Reporter:  mechter        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.4.2
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |     Focuses:
---------------------------+------------------------------

Comment (by mechter):

 @karmatosed Okay, so only one person noticed this and cared enough to
 report it. That doesn't seem so unusual to me. It's certainly enough to
 warrant taking a look.

 Regarding your second consideration, I suggest you do just that: Take a
 look for yourself, so you can see what it's actually like. Please visit
 the demo site at https://twentyfifteendemo.wordpress.com using a
 JavaScript-enabled browser. Make the browser window wide enough that you
 see the sidebar on the left, and reduce the height of the window so that
 you can see only the top three navigation menu items. This is to simulate
 a long sidebar. Notice the first nav item is called "About Twenty
 Fifteen". Scroll down a bit. Notice the sidebar scrolling together with
 the content. Scroll down further. Notice how at some point the sidebar
 becomes sticky, giving you quick access to its contents as you continue to
 scroll down. Pretend you're reading a long article. When you have scrolled
 all the way to the bottom of the page, imagine you wanted to learn more
 about Twenty Fifteen, and you recall the "About Twenty Fifteen" link from
 before. Scroll up a little. Before the change in question, sidebar and
 content would have scrolled up together until the top of the sidebar was
 reached, at which point it would have become sticky again. This would have
 allowed you to access the navigation item you are looking for right about
 now. As you keep scrolling all the way to the top of the page, ask
 yourself whether anyone could actually miss having to do this, even if
 they have come to expect it by now.

 As for further discussion, I hope that, after the practical demonstration
 above, we are now on the same page as to the validity of the bug and the
 relevance of fixing it even today. In any case, I'm grateful you responded
 to the ticket, as it has gotten a bit stale. Perhaps our discussion will
 catch the attention of someone with the knowledge, time, and motivation to
 create a patch. The tricky part is fixing the bug without accidentally
 introducing another regression in the process. The people who introduced
 the bug had reasons to make changes that a new patch should probably take
 into consideration. I have mentioned the authors of those changes in the
 original report, hoping they'd be notified and quickly address the issue,
 but they haven't responded yet. In the spirit of getting a wider range of
 opinions, I'll mention them again: @DvanKooten, @whyisjake. Also, would
 you like to share your thoughts on this, @iamtakashi? Having originally
 designed the Twenty Fifteen theme and currently working for Automattic
 would seem to put you in a good position to fix this bug.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50446#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform