[wp-trac] [WordPress Trac] #60872: Twenty Nineteen : Read More Block Text Decoration is not working properly

[WordPress Trac]

#60872: Twenty Nineteen : Read More Block Text Decoration is not working properly
-------------------------------------------------+-------------------------
 Reporter:  pitamdey                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch changes-   |     Focuses:  css
  requested                                      |
-------------------------------------------------+-------------------------
Changes (by poena):

 * keywords:  has-screenshots => has-screenshots has-patch changes-requested


Comment:

 Hi

 I can reproduce the issue with the styles in the editor and front not
 matching. (6.6 alpha, theme version 2.8).

 When the text decoration option is explicitly set to no underline,
 underline or strikethrough, the style works both in the editor and front
 because the style is inline in the style attribute.  But the **default**
 does not match:
 The default style for the **block** is to not show the underline.
 The default style for the **theme** is to show the underline.


 With the PR, all text decoration settings work, as well as the default.
 The PR changes the link style of the read more on the front of the site,
 this is minor, but it is an unexpected change on existing sites. The link
 style no longer matches the original theme design, or other links in the
 content.


 I would like to make the following change requests:
 - Twenty Nineteen uses SASS. This means that any changes that are made
 directly to the .css files will be overwritten when the SASS files are
 built. CSS changes need to made in the .scss files.
 - **Try** adding the underline to the block in the editor instead, so that
 the editor matches the front.
 - Make sure that all text decoration settings still work after changing
 the editor style.


 I believe this is the WordPress core editor block style that needs to be
 overwritten:

 {{{
 .wp-block-read-more:where(:not([style*=text-decoration])) {
     text-decoration: none;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60872#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform