[wp-trac] [WordPress Trac] #58901: Flush 'user_activation_key' after successfully login

WordPress Trac noreply at wordpress.org
Mon Sep 25 20:24:39 UTC 2023


#58901: Flush 'user_activation_key' after successfully login
-------------------------------------------------+-------------------------
 Reporter:  nsinelnikov                          |       Owner:
                                                 |  rajinsharwar
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.5
Component:  Login and Registration               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing needs-refresh                          |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * milestone:  6.4 => 6.5


Comment:

 In [attachment:"58901.diff"], directly invoking the `__set()` magic method
 is not preferred. And `'user_activation_key'` is a dynamic property (i.e.
 undeclared property of `WP_User`) that is incompatible with PHP 8.2 and
 beyond.

 I think this needs more consideration of how to reset the cached
 activation key. More test reports before and after would also be helpful.

 Tomorrow being Beta 1. Moving it to 6.5 to give the ticket more time.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58901#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list