[wp-trac] [WordPress Trac] #58775: Remove usage of outputting styles tags

WordPress Trac noreply at wordpress.org
Mon Sep 25 18:46:15 UTC 2023


#58775: Remove usage of outputting styles tags
--------------------------------+---------------------------
 Reporter:  spacedmonkey        |       Owner:  spacedmonkey
     Type:  enhancement         |      Status:  reopened
 Priority:  normal              |   Milestone:  6.4
Component:  Script Loader       |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  2nd-opinion revert  |     Focuses:  performance
--------------------------------+---------------------------
Changes (by azaozz):

 * keywords:  has-patch close 2nd-opinion => 2nd-opinion revert
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @flixos90:

 > That is not a benefit of this PR. You can already do that today by
 unhooking the functions that print it.

 Yes, for some of these. So if this is not the benefit, then what is the
 benefit of this refactoring?

 >
 The PR ensures those core styles make use of the WP_Styles API and thus
 can be properly depended upon, which isn't possible as of today.

 Sorry but I don't understand what you are saying? This is simply **not
 true**! Using the WP_Styles API does not improve handling of these styles
 in the lightest. Please add examples!

 At this time it seems that this change is a "pointless refactoring". There
 are no fixes or improvements as a result of it. Please see the WordPress
 philosophy in regards to doing pointless refactoring. On top of that it
 could bring new bugs or regressions.

 In these terms I think it should be reverted until a proof that it is
 actually beneficial for something.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58775#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list