[wp-trac] [WordPress Trac] #55491: Replace `unload` event handlers from core

WordPress Trac noreply at wordpress.org
Wed Sep 20 18:11:36 UTC 2023


#55491: Replace `unload` event handlers from core
----------------------------+--------------------------------------
 Reporter:  shawfactor      |       Owner:  westonruter
     Type:  enhancement     |      Status:  accepted
 Priority:  normal          |   Milestone:  6.4
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, performance
----------------------------+--------------------------------------

Comment (by westonruter):

 Replying to [comment:16 westonruter]:
 > One of the instances of `unload` is coming from the TinyMCE vendor
 dependency,
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/tinymce/tinymce.js#L1254
 src/js/_enqueues/vendor/tinymce/tinymce.js]:

 I filed an [https://github.com/jquery/sizzle/issues/498 issue with the
 Sizzle library] to remove `unload`, but I then found that Sizzle itself is
 [https://github.com/jquery/sizzle/issues/495#issuecomment-1430506064
 deprecated]. So it is unlikely that this code will be removed. Since it is
 bundled with TinyMCE 4.x which is also an old release branch, and since
 there is an [https://github.com/WordPress/gutenberg/pull/50387 experiment]
 to stop loading TinyMCE by default in the block editor, it seems patching
 TinyMCE here isn't going to be critical.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55491#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list