[wp-trac] [WordPress Trac] #57590: Class attribute for register and lost password link on login page

WordPress Trac noreply at wordpress.org
Tue Sep 19 22:25:39 UTC 2023


#57590: Class attribute for register and lost password link on login page
--------------------------------------+-----------------------
 Reporter:  wparslan                  |       Owner:  costdev
     Type:  enhancement               |      Status:  accepted
 Priority:  low                       |   Milestone:  6.4
Component:  Login and Registration    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch good-first-bug  |     Focuses:  ui, css
--------------------------------------+-----------------------
Changes (by costdev):

 * keywords:  has-patch changes-requested good-first-bug => has-patch good-
     first-bug


Comment:

 > for consistency we should also have corresponding classes on the
 Register screen – `wp-register.php`.
 > [https://core.trac.wordpress.org/ticket/57590#comment:6 comment:6]

 `wp-register.php` was removed from the repository in [20596].

 This file will still be there for sites that existed since before
 WordPress 3.4, but as it no longer exists in the repository, there is no
 file available for us to patch.


 I agree with earlier feedback provided in
 [https://core.trac.wordpress.org/ticket/57590#comment:2 comment:2] that
 `.log-in`, `.register` and `.lost-password` are too generic for this
 screen. Those classes are likely to be used in existing frontend CSS,
 which may be loaded into the login screen as well.

 [https://core.trac.wordpress.org/attachment/ticket/57590/57590.1.diff
 57590.1.diff] adds a `wp-login-` prefix to the classes to make them less
 generic, producing `.wp-login-log-in`, `.wp-login-register` and `.wp-
 login-lost-password`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57590#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list