[wp-trac] [WordPress Trac] #59389: Coding Standards: Use `implode` instead of `join` in tests/phpunit/tests/media.php and tests/phpunit/tests/media/getPostGalleries.php

WordPress Trac noreply at wordpress.org
Tue Sep 19 12:23:33 UTC 2023


#59389: Coding Standards: Use `implode` instead of `join` in
tests/phpunit/tests/media.php and
tests/phpunit/tests/media/getPostGalleries.php
------------------------------+-------------------------------
 Reporter:  david.binda       |       Owner:  costdev
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  6.4
Component:  General           |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  coding-standards
------------------------------+-------------------------------
Changes (by costdev):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56616" 56616]:
 {{{
 #!CommitTicketReference repository="" revision="56616"
 Coding Standards: Replace PHP alias `join()` with `implode()`.

 In [52190], some new instances of the `join()` alias were introduced in
 the test suite.

 Using the canonical function name for PHP functions is strongly
 recommended, as aliases may be deprecated or removed without (much)
 warning.

 This replaces the new `join()` uses with the canonical `implode()`
 function name.

 Follow-up to [46182], [49193], [49805], [52190].

 Props david.binda, mukesh27.
 Fixes #59389.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59389#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list