[wp-trac] [WordPress Trac] #59306: Add writing-mode as a typography block support

WordPress Trac noreply at wordpress.org
Mon Sep 18 04:56:18 UTC 2023


#59306: Add writing-mode as a typography block support
---------------------------------------+---------------------
 Reporter:  poena                      |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  6.4
Component:  Editor                     |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  gutenberg-merge has-patch  |     Focuses:
---------------------------------------+---------------------

Comment (by isabel_brison):

 Changes LGTM; there was a linting error which I fixed in the attached PR:
 https://github.com/WordPress/wordpress-develop/pull/5210

 I was wondering if we should add a test for this feature in the typography
 test suite: https://github.com/WordPress/wordpress-
 develop/blob/trunk/tests/phpunit/tests/block-supports/typography.php but
 we're not being consistent with tests for other discreet features such as
 letter-spacing or text-decoration so I guess we could leave this as is and
 revisit those tests later as a whole.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59306#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list