[wp-trac] [WordPress Trac] #59347: Typo on the Gettext_Translations class

[WordPress Trac]

#59347: Typo on the Gettext_Translations class
-----------------------------+-------------------------------
 Reporter:  tohincoderex     |       Owner:  (none)
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  General          |     Version:  6.3.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:  coding-standards
-----------------------------+-------------------------------
Changes (by jrf):

 * keywords:  has-patch => has-patch close
 * focuses:  coding-standards, php-compatibility => coding-standards


Comment:

 @tohincoderex Thanks for opening this ticket and bringing this to our
 attention.

 This file is regarded as a file from an external dependency and should for
 that reason not be changed without due cause.

 Renaming the function would break every single function call to that
 function and would cause fatal errors. Breaking changes like that are not
 acceptable.

 The typo has been in the original external dependency since (at least)
 2009.
 Of course, the function could be deprecated, a new function without the
 typo introduced and calls to the function could be updated, but as this is
 an external dependency, that is the kind of change we normally do not do
 for those kind of files (at least, not unless the change has first been
 made in the externally maintained code first).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59347#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform