[wp-trac] [WordPress Trac] #58443: Twenty Nineteen Button is having issue with line height.

[WordPress Trac]

#58443: Twenty Nineteen Button is having issue with line height.
-------------------------------------------------+-------------------------
 Reporter:  nidhidhandhukiya                     |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:  6.2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-patch has-      |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-testing-info has-patch has-screenshots commit => has-
     testing-info has-patch has-screenshots


Comment:

 Using `inherit` was not the best way to fix custom `line-height`.

 On the front end,
 [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/sass/forms/_buttons.scss#L16
 all button-like elements] have had a `line-height` of 1.2 since
 [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/sass/blocks/_blocks.scss#L130
 initial commit], and it needs to stay that value when users do not select
 their own. This ticket did not change the front-end `style.css` and the
 RTL was reverted, so the current state is still only wrong with a custom
 `line-height`.

 The editor's value of 1.8 did not match the front, but removing the entire
 line can be better than changing to `inherit`.

 //Any// of the customizable properties probably could be moved to the `wp-
 block-button` or `wp-block-buttons` element instead of the link.

 **If** tests are still giving any errors, that might be related to the
 missing space after the colon in `style-editor.scss`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58443#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform