[wp-trac] [WordPress Trac] #22192: update_metadata() and update_option() strict checks can cause false negatives

WordPress Trac noreply at wordpress.org
Wed Sep 13 10:54:08 UTC 2023


#22192: update_metadata() and update_option() strict checks can cause false
negatives
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:  mukesh27
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion dev-feedback   |     Focuses:
  has-unit-tests                                 |  performance
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 As flagged on the [https://github.com/WordPress/wordpress-
 develop/pull/5139#pullrequestreview-1622342055 PR].

 @mukesh27 I recommend doing the following.

 1. Change and title and description of this ticket to reflect that changes
 will only effect options.
 2. Create two new tickets, for metadata and network options.
 3. Remove changes from PR that affect network options.
 4. Create new PR for network options and port over network options based
 on existing PR.

 I agree with @flixos90 let's not grow the scope of this ticket. On the
 other hand, I think the network options change is simple tweak once the
 options are committed and should be worked on / commit in the same
 release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/22192#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list