[wp-trac] [WordPress Trac] #59203: Twenty Nineteen: fix Separator block's full-width size and placement (was: Twenty Ninteen - Separator block is having issue when default and full-width is selected.)

[WordPress Trac]

#59203: Twenty Nineteen: fix Separator block's full-width size and placement
-----------------------------------------+------------------------------
 Reporter:  nidhidhandhukiya             |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Bundled Theme                |     Version:  6.3
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  css
-----------------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  has-patch => has-patch changes-requested
 * focuses:   => css


Comment:

 The Separator block needs to remain `2.25rem` for the Default style when
 it has no alignment, center or Wide width.

 The Full width alignment probably could span the full page width in
 //both// the Default and Wide Line styles, overiding the `max-width` in
 `sass/blocks/_blocks.scss`.

 {{{
         .wp-block-separator.alignfull {
                 max-width: none;
         }
 }}}

 In `style-editor.scss`, the width could be 100% for Default and Wide Line
 styles:

 {{{
 .wp-block[data-align="full"] .wp-block-separator:not(.is-style-dots) {
         width: 100%;
 }
 }}}

 To fix the missing margin in the iframe editor, the editor styles need to
 add a selector such as `block-editor-iframe__body` (it was already
 adjusted in [48602] and [52925]).
 {{{
                 &.block-editor-iframe__body,
                 &.block-editor-writing-flow,
                 .block-editor-writing-flow {
                         max-width: 80%;
                         margin: 0 10%;
                 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59203#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform