[wp-trac] [WordPress Trac] #58738: Widgets page: Add missing H1 and admin notice when JS is off

[WordPress Trac]

#58738: Widgets page: Add missing H1 and admin notice when JS is off
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.4
Component:  Widgets                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch needs-testing has-testing-   |  administration
  info                               |
-------------------------------------+-------------------------------------

Comment (by afercia):

 Thank you all for the patch and for the testing. A few thoughts:

 1
 If we want to provide two Activate / Install links conditionally, then I'd
 think we should do the same for the edit post screen, for the Classic
 Editor plugin, to be consistent.

 2
 How would the `blocks-widgets_no_javascript_message` filter work now that
 the code provides 2 different messages?

 3
 I'd use a more consistent wording. For example, the message for the post
 editor is:


 {{{
 __( 'The block editor requires JavaScript. Please enable JavaScript in
 your browser settings, or try the <a href="%s">Classic Editor plugin</a>.'
 ),
 }}}

 For the Widgets, I'd use a similar wording:


 {{{
 __( 'The block widgets require JavaScript. Please enable JavaScript in
 your browser settings, or activate the <a href="%s">Classic Widgets
 plugin</a>.' ),
 }}}


 and


 {{{
 __( 'The block widgets require JavaScript. Please enable JavaScript in
 your browser settings, or try the <a href="%s">Classic Widgets
 plugin</a>.' ),
 }}}


 4
 Please double check some coding standards, e.g. missing spaces within
 parenthesis.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58738#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform