[wp-trac] [WordPress Trac] #59569: wp_pattern_category is set public to true, when it should have been false.

[WordPress Trac]

#59569: wp_pattern_category is set public to true, when it should have been false.
--------------------------+---------------------
 Reporter:  vrajadas      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.4
Component:  Taxonomy      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+---------------------
Changes (by hellofromTonya):

 * keywords:   => needs-patch


Comment:

 Thank you @glendaviesnz for explaining :) I get it.

 Replying to [comment:4 glendaviesnz]:
 > With 53835 it was set to `public`, because this taxonomy is intended for
 use by users either via the admin interface at `/wp-admin/edit-
 tags.php?taxonomy=wp_pattern_category` or via the UI added to the editor,
 so setting public to true seemed like the correct option. We may have
 misunderstood the meaning of public in this context though because
 /wp-`admin/edit-tags.php?taxonomy=wp_pattern_category` is still accessible
 even if it is set to `false` as you note.

 As long as it's intended for use within the admin only, it should work
 with the `public` set to `false`. In my testing, the pattern categories
 are still accessible within:

 * Pattern Categories `wp-admin/edit-tags.php?taxonomy=wp_pattern_category`
 * Site editor
 * Post/Page editors

 >Should we put up a patch to switch this back to false?

 As long as it is working in all admin UIs, then yes, please.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59569#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform