[wp-trac] [WordPress Trac] #59569: wp_pattern_category is set public to true, when it should have been false.

WordPress Trac noreply at wordpress.org
Tue Oct 31 20:36:16 UTC 2023


#59569: wp_pattern_category is set public to true, when it should have been false.
--------------------------+---------------------
 Reporter:  vrajadas      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.4
Component:  Taxonomy      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------
Changes (by hellofromTonya):

 * milestone:  Awaiting Review => 6.4


Comment:

 Hello @vrajadas,

 Welcome to WordPress Core's Trac :) Sorry for the delay in responding to
 your ticket.

 The change: #59379 / [56642].
 It was [https://github.com/WordPress/gutenberg/pull/53163 originally set]
 to `false`, but then changed in
 [https://github.com/WordPress/gutenberg/pull/53835 Gutenberg PR 53835],
 which added the UI and ability to assign categories to the user created
 patterns.

 Hmm I also wonder why the `public` arg is set to `true`. Tested with it
 set to `false` and am able to add, see, and update pattern categories.

 Pinging the contributors for discover the reasoning @glendaviesnz
 @isabel_brison @mamaduka.

 Pulling into 6.4 for awareness and discussion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59569#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list