[wp-trac] [WordPress Trac] #58264: Adding spinner to submit_button with wrap

[WordPress Trac]

#58264: Adding spinner to submit_button with wrap
----------------------------+-------------------------------------------
 Reporter:  msolution       |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  6.2
 Severity:  normal          |  Resolution:
 Keywords:  2nd-opinion     |     Focuses:  ui, administration, template
----------------------------+-------------------------------------------
Changes (by sabernhardt):

 * keywords:   => 2nd-opinion
 * component:  General => Administration


Comment:

 I do not think adding a sixth argument to the functions would help. See
 ticket:20490#comment:5, ticket:20492#comment:2 and ticket:31749#comment:4.

 The [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/widgets-
 form.php?rev=56573#L482 classic widgets form] used `false` for the `$wrap`
 argument and added spinner markup, and the
 [https://core.trac.wordpress.org/browser/tags/6.3/src/wp-
 admin/includes/options.php#L98 general settings page] creates a different
 spinner for new language installations. Several plugins use `false` and
 include their own spinner and container markup (including
 [https://plugins.trac.wordpress.org/browser/jetpack/tags/12.7.1/modules
 /contact-form/admin.php#L970 Jetpack],
 [https://plugins.trac.wordpress.org/browser/elementskit-
 lite/tags/3.0.0/modules/megamenu/views/options-menu-item.php#L167
 ElementsKit Elementor addons] and
 [https://plugins.trac.wordpress.org/browser/the-events-
 calendar/tags/6.2.4/src/Tribe/Ignored_Events.php#L180 The Events
 Calendar]).

 I could suggest making a consistent spinner for both Core and plugins to
 use, but even Core has at least two different implementations.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58264#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform