[wp-trac] [WordPress Trac] #59738: `wp_prime_option_caches()` makes DB queries for known non-existent options (notoptions).

[WordPress Trac]

#59738: `wp_prime_option_caches()` makes DB queries for known non-existent options
(notoptions).
--------------------------------------+--------------------------
 Reporter:  peterwilsoncc             |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  6.4
Component:  Options, Meta APIs        |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------

Comment (by hellofromTonya):

 @peterwilsoncc and I chatted (in my late last night) to better understand
 what users could expect from these bugs (i.e. without a fix shipping in
 6.4.0):

 * Severity is low.
 * Worse case: would cause extra DB queries.

 Should it be included in 6.4.0?

 As @mikeschroder noted,
 [https://make.wordpress.org/core/2023/10/17/wordpress-6-4-release-
 candidate-phase/ the RC process guidelines state]:

 >Regressions: bugs that have been introduced during the WordPress 6.4
 development cycle, either to existing or new features.

 The bugs were introduced during this cycle. Given RC3 is in a few days and
 final in a little over a week, risks need to be mitigated at this late
 stage in the release. Thus, I'd be okay with it going into 6.4.0 if:
 * there's ''high confidence'' in the fix (i.e. code reviews, automated
 tests, and manual test reports).
 * code changes are minimal.

 More significant, risky, and/or non-high confidence changes could be
 targeted for 6.4.1, i.e. to give more time for discussion, consideration,
 and testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59738#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform