[wp-trac] [WordPress Trac] #58962: Provide a way to load multiple specific options with a single database request

[WordPress Trac]

#58962: Provide a way to load multiple specific options with a single database
request
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests has-dev-    |     Focuses:
  note dev-reviewed                              |  performance
-------------------------------------------------+-------------------------

Comment (by flixos90):

 @peterwilsoncc
 > I am really disappointed in this action and think it goes well beyond
 the spirit and intent of double sign off.
 >
 > Tonya and I are both very experienced committers and were continuing the
 discussion. Tonya is the tech lead of the current release.
 >
 > I had chosen not to commit anything while the discussion was ongoing and
 find it quite disrespectful that you did not observe the same courtesy.

 I had committed the initial name change before you commented yesterday, so
 there was no way for me to anticipate you pushing back again. I committed
 the backport because the other name change was already committed, as we
 must certainly avoid having differently named functions in `trunk` vs the
 current release branch. Until 6.4 is released, none of this is definite.
 That said, the backport had the double sign off so while I understand that
 you still do not agree with the current naming, what I did did not go
 against the principle of double signoff.

 In any case: You disagree with the current naming and have presented your
 rationale, but I disagree with that rationale. We can continue arguing
 back and forth, but unless any of us can make additional arguments, I
 don't see the point. Both @joemcgill and I agree with the current naming,
 and as far as I understand @hellofromTonya was pointing out additional
 considerations for the naming without strongly leaning in one or the other
 direction.

 While what I'm saying may come across harsh, I am trying to be clear. I am
 not dismissing your opinion. But sometimes, it can happen that there is no
 consensus between everyone, and a decision has to be made regardless in
 order to move forward, either based on a committer majority or a decision
 by a lead. To map out a worst-case scenario here, it's certainly not worth
 for instance reverting this entire enhancement over a naming discussion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58962#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform